lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 10 Aug 2021 18:04:11 +0300
From:   Sakari Ailus <>
To:     Evgeny Novikov <>
Cc:     Mauro Carvalho Chehab <>,
        Greg Kroah-Hartman <>,
        Alex Dewar <>,
        Colin Ian King <>,
        Linus Walleij <>,,,,
Subject: Re: [PATCH] media: atomisp: Fix error handling in probe

On Tue, Aug 10, 2021 at 02:53:03PM +0300, Evgeny Novikov wrote:
> There were several issues with handling errors in lm3554_probe():
> - Probe did not set the error code when v4l2_ctrl_handler_init() failed.
> - It intermixed gotos for handling errors of v4l2_ctrl_handler_init()
>   and media_entity_pads_init().
> - Probe did not free resources in case of failures of
>   atomisp_register_i2c_module().
> The patch fixes all these issues.
> Found by Linux Driver Verification project (
> Signed-off-by: Evgeny Novikov <>

Acked-by: Sakari Ailus <>

Sakari Ailus

Powered by blists - more mailing lists