lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 10 Aug 2021 16:26:49 +0100
From:   David Howells <>
To:     "Matthew Wilcox (Oracle)" <>
        Christoph Hellwig <>,
        "Kirill A . Shutemov" <>
Subject: Re: [PATCH v14 001/138] mm: Convert get_page_unless_zero() to return bool

Matthew Wilcox (Oracle) <> wrote:

> atomic_add_unless() returns bool, so remove the widening casts to int
> in page_ref_add_unless() and get_page_unless_zero().  This causes gcc
> to produce slightly larger code in isolate_migratepages_block(), but
> it's not clear that it's worse code.  Net +19 bytes of text.
> Signed-off-by: Matthew Wilcox (Oracle) <>
> Reviewed-by: Christoph Hellwig <>
> Acked-by: Kirill A. Shutemov <>

Reviewed-by: David Howells <>

Powered by blists - more mailing lists