linux-kernel - Re: [PATCH 04/12] ASoC: cs42l42: Don't reconfigure the PLL while it is running

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210810154959.GD4704@sirena.org.uk>
Date:   Tue, 10 Aug 2021 16:49:59 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc:     alsa-devel@...a-project.org, patches@...nsource.cirrus.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/12] ASoC: cs42l42: Don't reconfigure the PLL while it
 is running

On Tue, Aug 10, 2021 at 04:37:51PM +0100, Richard Fitzgerald wrote:
> cs42l42_pcm_hw_params() must only configure the PLL if this is the first
> stream to become active, otherwise it will be overwriting the registers
> while the PLL is running.

Shouldn't the PLL code be noticing problematic attempts to reconfigure
the PLL while it's active rather than the individual callers?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)