linux-kernel - Re: [PATCH] tracing / histogram: Fix NULL pointer dereference on strcmp() on NULL event name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Aug 2021 10:29:10 -0500
From:   Tom Zanussi <zanussi@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH] tracing / histogram: Fix NULL pointer dereference on
 strcmp() on NULL event name

Hi Steve,

On Wed, 2021-08-11 at 10:35 -0400, Steven Rostedt wrote:
> On Sun, 8 Aug 2021 00:30:11 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > diff --git a/kernel/trace/trace_events_hist.c
> > b/kernel/trace/trace_events_hist.c
> > index 949ef09dc537..a48aa2a2875b 100644
> > --- a/kernel/trace/trace_events_hist.c
> > +++ b/kernel/trace/trace_events_hist.c
> > @@ -3430,6 +3430,8 @@ trace_action_create_field_var(struct
> > hist_trigger_data *hist_data,
> >  			event = data->match_data.event;
> >  		}
> >  
> > +		if (!event)
> > +			goto free;
> >  		/*
> >  		 * At this point, we're looking at a field on another
> >  		 * event.  Because we can't modify a hist trigger on
> > -- 
> 
> Tom,
> 
> Is this OK? I'm going to start running this through my tests and when
> it's done, I'm going to send it off to Linus.

Sorry, missed this one.

But yeah, this fixes the problem, thanks!

Reviewed-by: Tom Zanussi <zanussi@...nel.org>


> 
> -- Steve