linux-kernel - Re: [PATCH v2 2/6] staging: r8188eu: Remove wrapper around vfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Aug 2021 18:45:55 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Larry Finger <Larry.Finger@...inger.net>, phil@...lpotter.co.uk,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/6] staging: r8188eu: Remove wrapper around vfree

On Wed, Aug 11, 2021 at 08:44:12AM -0700, Guenter Roeck wrote:
> On Mon, Aug 02, 2021 at 02:27:17PM -0500, Larry Finger wrote:
> > This call is so simple that there is no need, or use, for a wrapper.
> > 
> 
> Except the wrapper was presumably there to map generic code to Linux
> code, and the patch doesn't add an include <linux/vmalloc.h> anywhere.
> This results in widespread build errrors such as
> 
> drivers/staging/r8188eu/core/rtw_mlme.c: In function '_rtw_free_mlme_priv':
> drivers/staging/r8188eu/core/rtw_mlme.c:129:17: error: implicit declaration of function 'vfree'
> 
> for all architectures where <linux/vmalloc.h> isn't included indirectly.

Has now been fixed up in my tree and will show up in the next
linux-next.

sorry about that,

greg k-h