linux-kernel - Re: [PATCH v1] dt-bindings: timer: fsl,imxgpt: add optional osc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YRQRNrLXIYERa6FT@robh.at.kernel.org>
Date:   Wed, 11 Aug 2021 12:04:38 -0600
From:   Rob Herring <robh@...nel.org>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        devicetree@...r.kernel.org, Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v1] dt-bindings: timer: fsl,imxgpt: add optional osc_per
 clock

On Tue, Aug 03, 2021 at 09:29:58AM +0200, Oleksij Rempel wrote:
> Add optional osc_per and fix dts validation warnings on imx6 SoCs.
> 
> Fixes: df8cad689eae ("dt-bindings: timer: Convert i.MX GPT to json-schema")

I don't think you can say the above commit was broken.

> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
>  .../devicetree/bindings/timer/fsl,imxgpt.yaml   | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> index a4f51f46b7a1..e496dd9f4988 100644
> --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> @@ -43,11 +43,15 @@ properties:
>      items:
>        - description: SoC GPT ipg clock
>        - description: SoC GPT per clock
> +      - description: optional SoC GPT oscillator
> +    minItems: 2

The 3rd clock is valid on every version of the h/w?

>  
>    clock-names:
>      items:
>        - const: ipg
>        - const: per
> +      - const: osc_per
> +    minItems: 2
>  
>  required:
>    - compatible
> @@ -70,3 +74,16 @@ examples:
>                   <&clks IMX27_CLK_PER1_GATE>;
>          clock-names = "ipg", "per";
>      };
> +
> +  - |
> +    #include <dt-bindings/clock/imx6qdl-clock.h>
> +
> +    timer@...8000 {
> +        compatible = "fsl,imx6q-gpt", "fsl,imx31-gpt";
> +        reg = <0x02098000 0x4000>;
> +        interrupts = <26>;
> +        clocks = <&clks IMX6QDL_CLK_GPT_IPG>,
> +                 <&clks IMX6QDL_CLK_GPT_IPG_PER>,
> +                 <&clks IMX6QDL_CLK_GPT_3M>;
> +        clock-names = "ipg", "per", "osc_per";
> +    };
> -- 
> 2.30.2
> 
>