linux-kernel - Re: [PATCH 07/18] ARC: ioremap: use more commonly used PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07c12487-dc65-9d2a-71a5-65b47c98a460@kernel.org>
Date:   Wed, 11 Aug 2021 11:58:27 -0700
From:   Vineet Gupta <vgupta@...nel.org>
To:     Mike Rapoport <rppt@...nel.org>, Vineet Gupta <vgupta@...nel.org>
Cc:     linux-snps-arc@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, Anshuman Khandual <anshuman.khandual@....com>
Subject: Re: [PATCH 07/18] ARC: ioremap: use more commonly used PAGE_KERNEL
 based uncached flag

On 8/10/21 10:18 PM, Mike Rapoport wrote:
>> -	return ioremap_prot(paddr, size, pgprot_val(PAGE_KERNEL_NO_CACHE));
>> +	return ioremap_prot(paddr, size,
>> +			    pgprot_val(pgprot_noncached(PAGE_KERNEL)));
> But this becomes _PAGE_CACHEABLE now. What did I miss?

We now use pgprot_noncached()

arch/arc/include/asm/pgtable.h:30:#define pgprot_noncached(prot)        
(__pgprot(pgprot_val(prot) & ~_PAGE_CACHEABLE))

-Vineet