linux-kernel - [BUG] staging: rtl8192e: possible null-pointer dereference in rtllib_wx_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <a86f508c-84b0-3523-2a8e-6710e35e5bb3@gmail.com>
Date:   Wed, 11 Aug 2021 11:33:57 +0800
From:   Tuo Li <islituo@...il.com>
To:     gregkh@...uxfoundation.org, will+git@...d.me,
        davidsondfgl@...il.com, zhaoxiao@...ontech.com,
        dan.carpenter@...cle.com
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        "baijiaju1990@...il.com" <baijiaju1990@...il.com>
Subject: [BUG] staging: rtl8192e: possible null-pointer dereference in
 rtllib_wx_set_encode()

Hello,

Our static analysis tool finds a possible null-pointer dereference in 
rtllib_wx.c in Linux 5.14.0-rc3:

The variable (*crypt)->ops is checked in:
342:    if (*crypt && (*crypt)->ops && strcmp((*crypt)->ops->name, 
"R-WEP") != 0)

This indicates that it can be NULL. If so, null-pointer dereferences 
will occur:
389:    (*crypt)->ops->set_key()
400:    len = (*crypt)->ops->get_key()

I am not quite sure whether this possible null-pointer dereference is 
real and how to fix it if it is real.
Any feedback would be appreciated, thanks!

Reported-by: TOTE Robot <oslab@...nghua.edu.cn>

Best wishes,
Tuo Li