linux-kernel - Re: [PATCH -next] spi: mxic: add missing braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OFF3887BAF.9F4586C4-ON4825872E.00113C05-4825872E.0011A20D@mxic.com.tw>
Date:   Wed, 11 Aug 2021 11:12:35 +0800
From:   zhengxunli@...c.com.tw
To:     "Yang Yingliang" <yangyingliang@...wei.com>
Cc:     broonie@...nel.org, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org
Subject: Re: [PATCH -next] spi: mxic: add missing braces

"Yang Yingliang" <yangyingliang@...wei.com> wrote on 2021/08/10 下午 
10:24:05:

> "Yang Yingliang" <yangyingliang@...wei.com> 
> 2021/08/10 下午 10:18
> 
> To
> 
> <linux-kernel@...r.kernel.org>, <linux-spi@...r.kernel.org>, 
> 
> cc
> 
> <broonie@...nel.org>, <zhengxunli@...c.com.tw>
> 
> Subject
> 
> [PATCH -next] spi: mxic: add missing braces
> 
> Fix the following waring:
> 
> drivers/spi/spi-mxic.c: In function ‘mxic_spi_mem_exec_op’:
> drivers/spi/spi-mxic.c:401:3: warning: this ‘if’ clause does not 
> guard... [-Wmisleading-indentation]
>    if (op->data.dir == SPI_MEM_DATA_IN)
>    ^~
> drivers/spi/spi-mxic.c:403:4: note: ...this statement, but the 
> latter is misleadingly indented as if it were guarded by the ‘if’
>     if (op->data.dtr)
>     ^~
> 
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

Reviewed-by: Zhengxun Li <zhengxunli@...c.com.tw>

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information 
and/or personal data, which is protected by applicable laws. Please be 
reminded that duplication, disclosure, distribution, or use of this e-mail 
(and/or its attachments) or any part thereof is prohibited. If you receive 
this e-mail in error, please notify us immediately and delete this mail as 
well as its attachment(s) from your system. In addition, please be 
informed that collection, processing, and/or use of personal data is 
prohibited unless expressly permitted by personal data protection laws. 
Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================

============================================================================

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================