linux-kernel - Re: [PATCH v2] i2c: dev: zero out array used for i2c reads from userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YRN8QHingopdwmxO@kroah.com>
Date:   Wed, 11 Aug 2021 09:29:04 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH v2] i2c: dev: zero out array used for i2c reads from
 userspace

On Tue, Aug 10, 2021 at 10:55:11PM +0200, Wolfram Sang wrote:
> On Thu, Jul 29, 2021 at 04:35:32PM +0200, Greg Kroah-Hartman wrote:
> > If an i2c driver happens to not provide the full amount of data that a
> > user asks for, it is possible that some uninitialized data could be sent
> > to userspace.  While all in-kernel drivers look to be safe, just be sure
> > by initializing the buffer to zero before it is passed to the i2c driver
> > so that any future drivers will not have this issue.
> > 
> > Also properly copy the amount of data recvieved to the userspace buffer,
> > as pointed out by Dan Carpenter.
> > 
> > Reported-by: Eric Dumazet <edumazet@...gle.com>
> > Cc: Dan Carpenter <dan.carpenter@...cle.com>
> > Cc: stable <stable@...r.kernel.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Fixed checkpatch warning "WARNING: Invalid email format for stable:
> 'stable <stable@...r.kernel.org>', prefer 'stable@...r.kernel.org' " and
> applied to for-current, thanks!

That is a crazy warning, never even knew it was there.  But as the
stable maintainer, it does not look correct as both are just fine...

Anyway, thanks for taking the patch!

greg k-h