linux-kernel - Re: [PATCH] ARM: NOMMU: Return true/false (not 1/0) from bool functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e30b659-a91a-58f6-f9aa-d0f0259eb9e8@arm.com>
Date:   Wed, 11 Aug 2021 09:58:42 +0100
From:   Vladimir Murzin <vladimir.murzin@....com>
To:     Huilong Deng <denghuilong@...rlc.com>, linux@...linux.org.uk,
        ira.weiny@...el.com, sfr@...b.auug.org.au,
        akpm@...ux-foundation.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: NOMMU: Return true/false (not 1/0) from bool
 functions

On 8/11/21 9:20 AM, Huilong Deng wrote:
> ./arch/arm/mm/nommu.c:59:8-9: WARNING: return of 0/1 in function
> 'security_extensions_enabled' with return type bool
> 
> Signed-off-by: Huilong Deng <denghuilong@...rlc.com>
> ---
>  arch/arm/mm/nommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mm/nommu.c b/arch/arm/mm/nommu.c
> index 2658f52903da..7256ac159acb 100644
> --- a/arch/arm/mm/nommu.c
> +++ b/arch/arm/mm/nommu.c
> @@ -56,7 +56,7 @@ static inline bool security_extensions_enabled(void)
>  	if ((read_cpuid_id() & 0x000f0000) == 0x000f0000)
>  		return cpuid_feature_extract(CPUID_EXT_PFR1, 4) ||
>  			cpuid_feature_extract(CPUID_EXT_PFR1, 20);
> -	return 0;
> +	return false;
>  }
>  
>  unsigned long setup_vectors_base(void)
> 

Reviewed-by: Vladimir Murzin <vladimir.murzin@....com>

Please, submit it into RMK's Patch system [1]

[1] https://www.armlinux.org.uk/developer/patches/

Cheers
Vladimir