linux-kernel - [vbabka:slub-local-lock-v4r1 29/35] mm/slub.c:4396:5: warning: no previous prototype for function '__kmem_cache_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202108110929.LthFDoAo-lkp@intel.com>
Date:   Wed, 11 Aug 2021 09:18:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     clang-built-linux@...glegroups.com, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, Vlastimil Babka <vbabka@...e.cz>
Subject: [vbabka:slub-local-lock-v4r1 29/35] mm/slub.c:4396:5: warning: no
 previous prototype for function '__kmem_cache_do_shrink'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git slub-local-lock-v4r1
head:   cb9b19ebd40aa23420fd5f8889fb4cd81ff346bc
commit: f141ef3ae9b1a6421e47136f93500ae74e1076e1 [29/35] mm: slub: Move flush_cpu_slab() invocations __free_slab() invocations out of IRQ context
config: riscv-buildonly-randconfig-r004-20210809 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 614c7d03877fd99c2de47429b15be3f00306a3bd)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git/commit/?id=f141ef3ae9b1a6421e47136f93500ae74e1076e1
        git remote add vbabka https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git
        git fetch --no-tags vbabka slub-local-lock-v4r1
        git checkout f141ef3ae9b1a6421e47136f93500ae74e1076e1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> mm/slub.c:4396:5: warning: no previous prototype for function '__kmem_cache_do_shrink' [-Wmissing-prototypes]
   int __kmem_cache_do_shrink(struct kmem_cache *s)
       ^
   mm/slub.c:4396:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __kmem_cache_do_shrink(struct kmem_cache *s)
   ^
   static 
   mm/slub.c:1556:21: warning: unused function 'kmalloc_large_node_hook' [-Wunused-function]
   static inline void *kmalloc_large_node_hook(void *ptr, size_t size, gfp_t flags)
                       ^
   2 warnings generated.


vim +/__kmem_cache_do_shrink +4396 mm/slub.c

  4386	
  4387	/*
  4388	 * kmem_cache_shrink discards empty slabs and promotes the slabs filled
  4389	 * up most to the head of the partial lists. New allocations will then
  4390	 * fill those up and thus they can be removed from the partial lists.
  4391	 *
  4392	 * The slabs with the least items are placed last. This results in them
  4393	 * being allocated from last increasing the chance that the last objects
  4394	 * are freed in them.
  4395	 */
> 4396	int __kmem_cache_do_shrink(struct kmem_cache *s)
  4397	{
  4398		int node;
  4399		int i;
  4400		struct kmem_cache_node *n;
  4401		struct page *page;
  4402		struct page *t;
  4403		struct list_head discard;
  4404		struct list_head promote[SHRINK_PROMOTE_MAX];
  4405		unsigned long flags;
  4406		int ret = 0;
  4407	
  4408		for_each_kmem_cache_node(s, node, n) {
  4409			INIT_LIST_HEAD(&discard);
  4410			for (i = 0; i < SHRINK_PROMOTE_MAX; i++)
  4411				INIT_LIST_HEAD(promote + i);
  4412	
  4413			spin_lock_irqsave(&n->list_lock, flags);
  4414	
  4415			/*
  4416			 * Build lists of slabs to discard or promote.
  4417			 *
  4418			 * Note that concurrent frees may occur while we hold the
  4419			 * list_lock. page->inuse here is the upper limit.
  4420			 */
  4421			list_for_each_entry_safe(page, t, &n->partial, slab_list) {
  4422				int free = page->objects - page->inuse;
  4423	
  4424				/* Do not reread page->inuse */
  4425				barrier();
  4426	
  4427				/* We do not keep full slabs on the list */
  4428				BUG_ON(free <= 0);
  4429	
  4430				if (free == page->objects) {
  4431					list_move(&page->slab_list, &discard);
  4432					n->nr_partial--;
  4433				} else if (free <= SHRINK_PROMOTE_MAX)
  4434					list_move(&page->slab_list, promote + free - 1);
  4435			}
  4436	
  4437			/*
  4438			 * Promote the slabs filled up most to the head of the
  4439			 * partial list.
  4440			 */
  4441			for (i = SHRINK_PROMOTE_MAX - 1; i >= 0; i--)
  4442				list_splice(promote + i, &n->partial);
  4443	
  4444			spin_unlock_irqrestore(&n->list_lock, flags);
  4445	
  4446			/* Release empty slabs */
  4447			list_for_each_entry_safe(page, t, &discard, slab_list)
  4448				discard_slab(s, page);
  4449	
  4450			if (slabs_node(s, node))
  4451				ret = 1;
  4452		}
  4453	
  4454		return ret;
  4455	}
  4456	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (35046 bytes)