linux-kernel - Re: [PATCH] [v2,1/1] This aims to support Foxconn SDX55

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875ywcfave.fsf@miraculix.mork.no>
Date:   Wed, 11 Aug 2021 14:01:57 +0200
From:   Bjørn Mork <bjorn@...k.no>
To:     Slark Xiao <slark_xiao@....com>
Cc:     johan@...nel.org, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2,1/1] This aims to support Foxconn SDX55

Slark Xiao <slark_xiao@....com> writes:

> diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
> index 83da8236e3c8..d8b58aea3c60 100644
> --- a/drivers/usb/serial/qcserial.c
> +++ b/drivers/usb/serial/qcserial.c
> @@ -111,6 +111,7 @@ static const struct usb_device_id id_table[] = {
>  	{USB_DEVICE(0x16d8, 0x8002)},	/* CMDTech Gobi 2000 Modem device (VU922) */
>  	{USB_DEVICE(0x05c6, 0x9204)},	/* Gobi 2000 QDL device */
>  	{USB_DEVICE(0x05c6, 0x9205)},	/* Gobi 2000 Modem device */
> +	{USB_DEVICE(0x05c6, 0x901d)},	/* Foxconn SDX55 QDL */

I assume this device will expose other serial functions when booted in
application USB mode?  But probably not with a Gobi 2k layout... Maybe
add the application device ID to some USB serial driver too, and include
the QDL device ID there as well to reduce confusion?

Could you provide a view of the default USB descriptors in both QDL and
application mode?  E.g from lsusb -v or  /sys/kernel/debug/usb/devices?

Bjørn