linux-kernel - Re: [PATCH v1 2/4] gpio: dwapb: Read GPIO base from gpio-base property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210811124753.nckmggmil47yytxz@mobilestation>
Date:   Wed, 11 Aug 2021 15:47:53 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Lee Jones <lee.jones@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Hoan Tran <hoan@...amperecomputing.com>
Subject: Re: [PATCH v1 2/4] gpio: dwapb: Read GPIO base from gpio-base
 property

Hello Linus

On Wed, Aug 11, 2021 at 02:40:49PM +0200, Linus Walleij wrote:
> On Wed, Aug 4, 2021 at 4:44 PM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> > On Wed, Aug 04, 2021 at 03:44:33PM +0300, Serge Semin wrote:
> > > Thus, yes, I think we need to make sure here that the property
> > > is only used in framework of the kernel and isn't passed via
> > > inappropriate paths like DT/ACPI fw so not to get into the
> > > maintainability troubles in future.
> >
> > Got it. I'll add the additional check in next version.
> 

> This seems reasonable for me, if you can get this done with
> some kind of elegance.
> 

There is v2 of this series has already been posted:
https://lore.kernel.org/linux-gpio/20210804160019.77105-1-andriy.shevchenko@linux.intel.com/
with the denoted concern taken into account. 

-Sergey

> Maybe use the "linux,gpio-base" property as mentioned so it is
> clear that this is a Linux-internal thing only.
> 
> Yours,
> Linus Walleij