linux-kernel - Re: [PATCH v2] f2fs: warn on when fsck flag is set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17ecb791-efa0-3e81-f9e5-eef321011b9e@kernel.org>
Date:   Wed, 11 Aug 2021 21:40:23 +0800
From:   Chao Yu <chao@...nel.org>
To:     Yangtao Li <frank.li@...o.com>, jaegeuk@...nel.org
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] f2fs: warn on when fsck flag is set

On 2021/8/11 21:30, Yangtao Li wrote:
> SBI_NEED_FSCK is an indicator that fsck.f2fs needs to be triggered,
> this flag is set in too many places. For some scenes that are not very reproducible,
> adding stack information will help locate the problem.
> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>
> ---
> v2:
> -convert to WARN_ON
> -one more blank
>   fs/f2fs/f2fs.h | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 67faa43cc141..2e2294234c0d 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -33,7 +33,7 @@
>   #else
>   #define f2fs_bug_on(sbi, condition)					\
>   	do {								\
> -		if (WARN_ON(condition))					\
> +		if ((condition))					\

Why removing WARN_ON()?

>   			set_sbi_flag(sbi, SBI_NEED_FSCK);		\
>   	} while (0)
>   #endif
> @@ -1999,6 +1999,8 @@ static inline bool is_sbi_flag_set(struct f2fs_sb_info *sbi, unsigned int type)
>   
>   static inline void set_sbi_flag(struct f2fs_sb_info *sbi, unsigned int type)
>   {
> +	WARN_ON(type ==  SBI_NEED_FSCK);

Again, please remove one unnecessary blank character before SBI_NEED_FSCK.

WARN_ON_ONCE(type == SBI_NEED_FSCK)

> +

No need to add blank line.

Thanks,

>   	set_bit(type, &sbi->s_flag);
>   }
>   
>