linux-kernel - Re: [PATCH] ASoC: rt5682: Properly turn off regulators if wrong device ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=W0rS0-EZQn3i1GxgYy2A4OhnMNk=W0WUSrFOssjnUOYw@mail.gmail.com>
Date:   Wed, 11 Aug 2021 08:19:32 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Stephen Boyd <swboyd@...omium.org>,
        Oder Chiou <oder_chiou@...ltek.com>,
        Bard Liao <bardliao@...ltek.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Liam Girdwood <lgirdwood@...il.com>,
        Takashi Iwai <tiwai@...e.com>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: rt5682: Properly turn off regulators if wrong
 device ID

Hi,

On Wed, Aug 11, 2021 at 8:04 AM Mark Brown <broonie@...nel.org> wrote:
>
> On Wed, Aug 11, 2021 at 07:40:59AM -0700, Doug Anderson wrote:
> > On Tue, Aug 10, 2021 at 9:24 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> > > Nit: Add newline here.
>
> > How strongly do you feel about it? I purposely left the newline off to
> > try to tie the devm_add_action_or_reset() more closely to the
> > devm_regulator_bulk_get(). I wanted to make it more obvious that the
> > two of them were "together" and shouldn't be split up. That being
> > said, it's no skin off my teeth to add a newline if everyone likes it
> > better. ;-)
>
> TBH the newline looks off before I've got as far as reading the code.

Fair 'nuff. v2 is posted with the blank line.

https://lore.kernel.org/r/20210811081751.v2.1.I4a1d9aa5d99e05aeee15c2768db600158d76cab8@changeid/

-Doug