linux-kernel - Re: [PATCH 3/5] staging: r8188eu: (trivial) remove a duplicate debug print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210812061759.GW22532@kadam>
Date:   Thu, 12 Aug 2021 09:17:59 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Phillip Potter <phil@...lpotter.co.uk>
Cc:     Martin Kaiser <martin@...ser.cx>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Michael Straube <straube.linux@...il.com>,
        linux-staging@...ts.linux.dev,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/5] staging: r8188eu: (trivial) remove a duplicate debug
 print

On Thu, Aug 12, 2021 at 12:53:16AM +0100, Phillip Potter wrote:
> On Wed, 11 Aug 2021 at 21:15, Martin Kaiser <martin@...ser.cx> wrote:
> >
> > Keep the one that shows the wakeup capability.
> >

Please think of the subject and the commit message as two different
things.  Often it's people reviewing on email will only read one or the
other.  In other words just restate the subject:

  These two debug messages have the same information.  Delete the less
  informative one and keep the other.

> Dear Martin,
> 
> Just my personal opinion, but I'd be inclined to strip out all DBG_88E
> calls totally. If there are necessary functions being called such as
> device_may_wakeup() we can always just keep this part and remove the
> macro call (not checked this function out myself yet). Thanks.
> 

Yeah.  I agree.  The DBG_88E() doesn't call device_may_wakeup() unless
the module is loaded with a high enough value "rtw_debug" module option
so hopefully device_may_wakeup() does not have side effects.  (It does
not).

Thanks for reviewing these patches.  I do think it's nice to have
positive reviews instead of just me complaining and pointing out the
negative things.  We are trying to get code merged, not trying to put up
roadblocks so maybe encouraging more Acked-by reviews is a good thing...

regards,
dan carpenter