linux-kernel - Re: [PATCH 2/2] riscv: defconfig: enable NLS_CODEPAGE_437, NLS_ISO8859

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Aug 2021 00:18:35 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     xypron.glpk@....de
CC:     Paul Walmsley <paul.walmsley@...ive.com>, aou@...s.berkeley.edu,
        heinrich.schuchardt@...onical.com,
        Atish Patra <Atish.Patra@....com>,
        Anup Patel <Anup.Patel@....com>, kernel@...il.dk,
        sagar.kadam@...ive.com, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, xypron.glpk@....de
Subject:     Re: [PATCH 2/2] riscv: defconfig: enable NLS_CODEPAGE_437, NLS_ISO8859_1

On Mon, 26 Jul 2021 04:26:47 PDT (-0700), xypron.glpk@....de wrote:
> The EFI system partition uses the FAT file system. Many distributions add
> an entry in /etc/fstab for the ESP. We must ensure that mounting does not
> fail.
>
> The default code page for FAT is 437 (cf. CONFIG_FAT_DEFAULT_CODEPAGE).
> The default IO character set is "iso8859-1" (cf. CONFIG_NLS_ISO8859_1).
>
> So let's enable NLS_CODEPAGE_437 and NLS_ISO8859_1 in defconfig.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@...onical.com>
> ---
>  arch/riscv/configs/defconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> index 393bf3843e5c..1a3170d5f203 100644
> --- a/arch/riscv/configs/defconfig
> +++ b/arch/riscv/configs/defconfig
> @@ -110,6 +110,8 @@ CONFIG_NFS_V4_1=y
>  CONFIG_NFS_V4_2=y
>  CONFIG_ROOT_NFS=y
>  CONFIG_9P_FS=y
> +CONFIG_NLS_CODEPAGE_437=y
> +CONFIG_NLS_ISO8859_1=m
>  CONFIG_CRYPTO_USER_API_HASH=y
>  CONFIG_CRYPTO_DEV_VIRTIO=y
>  CONFIG_PRINTK_TIME=y

These both look fine, but I'm getting checkpatch warnings about the 
Signed-off-by address not matching the From address.  Not sure if it's 
just something wrong on my end, but when I send from a different address 
then I want as the Author field I generally end up with a "From: " line 
at the top of my patch.

I know it's a bit pedantic, but IIUC I'm not supposed to take things 
like tihs.  Do you mind re-sending these as patches that are internally 
consistent?