linux-kernel - Re: [PATCH v2] platform/x86: ISST: Fix optimization with use of numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <119ab09f-9aab-9980-c1d3-72decff43488@redhat.com>
Date:   Thu, 12 Aug 2021 09:41:53 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        mgross@...ux.intel.com
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        sfr@...b.auug.org.au
Subject: Re: [PATCH v2] platform/x86: ISST: Fix optimization with use of numa

Hi,

On 8/11/21 5:36 AM, Srinivas Pandruvada wrote:
> When numa is used to map CPU to PCI device, the optimized path to read
> from cached data is not working and still calls _isst_if_get_pci_dev().
> 
> The reason is that when caching the mapping, numa information is not
> available as it is read later. So move the assignment of
> isst_cpu_info[cpu].numa_node before calling _isst_if_get_pci_dev().
> 
> Fixes: aa2ddd242572 ("platform/x86: ISST: Use numa node id for cpu pci dev mapping")
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> ---
> v2:
> Fixed "Fixes tag" as suggested by Stephen Rothwell

Thanks, but I just fixed this myself in the pdx86/for-next tree and I've
done a forced-push of for-next with the fixed Fixes tag.

Either way this is resolved now :)

Regards,

Hans




> 
> Update:
> 	The fixes tag was wrong
> This patch can wait for next merge window as these systems are not
> shipped.
> 
>  drivers/platform/x86/intel_speed_select_if/isst_if_common.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> index 6f0cc679c8e5..8a4d52a9028d 100644
> --- a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> +++ b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> @@ -379,6 +379,8 @@ static int isst_if_cpu_online(unsigned int cpu)
>  	u64 data;
>  	int ret;
>  
> +	isst_cpu_info[cpu].numa_node = cpu_to_node(cpu);
> +
>  	ret = rdmsrl_safe(MSR_CPU_BUS_NUMBER, &data);
>  	if (ret) {
>  		/* This is not a fatal error on MSR mailbox only I/F */
> @@ -397,7 +399,6 @@ static int isst_if_cpu_online(unsigned int cpu)
>  		return ret;
>  	}
>  	isst_cpu_info[cpu].punit_cpu_id = data;
> -	isst_cpu_info[cpu].numa_node = cpu_to_node(cpu);
>  
>  	isst_restore_msr_local(cpu);
>  
>