linux-kernel - Re: [PATCH 2/6] usb: mtu3: fix the wrong HS mult value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9b8b57550dc1f368d035e437fa8530c59c6576e.camel@mediatek.com>
Date:   Thu, 12 Aug 2021 11:51:32 +0000
From:   Chunfeng Yun (云春峰) 
        <Chunfeng.Yun@...iatek.com>
To:     "balbi@...nel.org" <balbi@...nel.org>
CC:     "rikard.falkeborn@...il.com" <rikard.falkeborn@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jonathanh@...dia.com" <jonathanh@...dia.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "bcm-kernel-feedback-list@...adcom.com" 
        <bcm-kernel-feedback-list@...adcom.com>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Eddie Hung (洪正鑫) 
        <Eddie.Hung@...iatek.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "alcooperx@...il.com" <alcooperx@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "christophe.jaillet@...adoo.fr" <christophe.jaillet@...adoo.fr>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "yangyingliang@...wei.com" <yangyingliang@...wei.com>,
        "pawell@...ence.com" <pawell@...ence.com>
Subject: Re: [PATCH 2/6] usb: mtu3: fix the wrong HS mult value

On Thu, 2021-08-12 at 09:49 +0300, Felipe Balbi wrote:
> Chunfeng Yun <chunfeng.yun@...iatek.com> writes:
> 
> > Use usb_endpoint_maxp() and usb_endpoint_maxp_mult() seperately
> > to get maxpacket and mult.
> > Meanwhile fix the bug that should use @mult but not @burst
> > to save mult value.
> 
> I really think you should split this into two patches. One which
> *only*
> fixes the bug and another (patch 2) which *only* corrects the use
> usb_endpoint_maxp()
Ok, thanks
>