linux-kernel - Re: [PATCH v14 063/138] mm/writeback: Rename __add_wb_stat() to wb_stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ed4b6a3-bd9a-c308-0c20-b1a3063d7728@suse.cz>
Date:   Thu, 12 Aug 2021 14:21:09 +0200
From:   Vlastimil Babka <vbabka@...e.cz>
To:     "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        linux-kernel@...r.kernel.org
Cc:     linux-mm@...ck.org, linux-fsdevel@...r.kernel.org,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v14 063/138] mm/writeback: Rename __add_wb_stat() to
 wb_stat_mod()

On 7/15/21 5:35 AM, Matthew Wilcox (Oracle) wrote:
> Make this look like the newly renamed vmstat functions.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> Reviewed-by: Christoph Hellwig <hch@....de>

Acked-by: Vlastimil Babka <vbabka@...e.cz>

> ---
>  include/linux/backing-dev.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index 44df4fcef65c..a852876bb6e2 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -64,7 +64,7 @@ static inline bool bdi_has_dirty_io(struct backing_dev_info *bdi)
>  	return atomic_long_read(&bdi->tot_write_bandwidth);
>  }
>  
> -static inline void __add_wb_stat(struct bdi_writeback *wb,
> +static inline void wb_stat_mod(struct bdi_writeback *wb,
>  				 enum wb_stat_item item, s64 amount)
>  {
>  	percpu_counter_add_batch(&wb->stat[item], amount, WB_STAT_BATCH);
> @@ -72,12 +72,12 @@ static inline void __add_wb_stat(struct bdi_writeback *wb,
>  
>  static inline void inc_wb_stat(struct bdi_writeback *wb, enum wb_stat_item item)
>  {
> -	__add_wb_stat(wb, item, 1);
> +	wb_stat_mod(wb, item, 1);
>  }
>  
>  static inline void dec_wb_stat(struct bdi_writeback *wb, enum wb_stat_item item)
>  {
> -	__add_wb_stat(wb, item, -1);
> +	wb_stat_mod(wb, item, -1);
>  }
>  
>  static inline s64 wb_stat(struct bdi_writeback *wb, enum wb_stat_item item)
>