linux-kernel - [PATCH] firmware: arm_sdei: Print sdei event number in hex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20210812152615.28930-1-vgomonovych@marvell.com>
Date:   Thu, 12 Aug 2021 08:26:14 -0700
From:   Vasyl Gomonovych <vgomonovych@...vell.com>
To:     <james.morse@....com>
CC:     Vasyl Gomonovych <vgomonovych@...vell.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: [PATCH] firmware: arm_sdei: Print sdei event number in hex

SDEI specified event numbers in hexadecimal format.
Change event number format to hexadecimal to make
it easier for the reader to recognize the proper event.

Signed-off-by: Vasyl Gomonovych <vgomonovych@...vell.com>
---
 drivers/firmware/arm_sdei.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
index a7e762c352f9..66d2869d03f7 100644
--- a/drivers/firmware/arm_sdei.c
+++ b/drivers/firmware/arm_sdei.c
@@ -496,7 +496,7 @@ int sdei_event_unregister(u32 event_num)
 	mutex_lock(&sdei_events_lock);
 	event = sdei_event_find(event_num);
 	if (!event) {
-		pr_warn("Event %u not registered\n", event_num);
+		pr_warn("Event 0x%x not registered\n", event_num);
 		err = -ENOENT;
 		goto unlock;
 	}
@@ -579,7 +579,7 @@ int sdei_event_register(u32 event_num, sdei_event_callback *cb, void *arg)
 
 	mutex_lock(&sdei_events_lock);
 	if (sdei_event_find(event_num)) {
-		pr_warn("Event %u already registered\n", event_num);
+		pr_warn("Event 0x%x already registered\n", event_num);
 		err = -EBUSY;
 		goto unlock;
 	}
@@ -587,7 +587,7 @@ int sdei_event_register(u32 event_num, sdei_event_callback *cb, void *arg)
 	event = sdei_event_create(event_num, cb, arg);
 	if (IS_ERR(event)) {
 		err = PTR_ERR(event);
-		pr_warn("Failed to create event %u: %d\n", event_num, err);
+		pr_warn("Failed to create event 0x%x: %d\n", event_num, err);
 		goto unlock;
 	}
 
@@ -605,7 +605,7 @@ int sdei_event_register(u32 event_num, sdei_event_callback *cb, void *arg)
 
 	if (err) {
 		sdei_event_destroy(event);
-		pr_warn("Failed to register event %u: %d\n", event_num, err);
+		pr_warn("Failed to register event 0x%x: %d\n", event_num, err);
 		goto cpu_unlock;
 	}
 
@@ -635,7 +635,7 @@ static int sdei_reregister_shared(void)
 					sdei_entry_point, event->registered,
 					SDEI_EVENT_REGISTER_RM_ANY, 0);
 			if (err) {
-				pr_err("Failed to re-register event %u\n",
+				pr_err("Failed to re-register event 0x%x\n",
 				       event->event_num);
 				sdei_event_destroy_llocked(event);
 				break;
@@ -645,7 +645,7 @@ static int sdei_reregister_shared(void)
 		if (event->reenable) {
 			err = sdei_api_event_enable(event->event_num);
 			if (err) {
-				pr_err("Failed to re-enable event %u\n",
+				pr_err("Failed to re-enable event 0x%x\n",
 				       event->event_num);
 				break;
 			}
@@ -670,7 +670,7 @@ static int sdei_cpuhp_down(unsigned int cpu)
 
 		err = sdei_do_local_call(_local_event_unregister, event);
 		if (err) {
-			pr_err("Failed to unregister event %u: %d\n",
+			pr_err("Failed to unregister event 0x%x: %d\n",
 			       event->event_num, err);
 		}
 	}
@@ -693,7 +693,7 @@ static int sdei_cpuhp_up(unsigned int cpu)
 		if (event->reregister) {
 			err = sdei_do_local_call(_local_event_register, event);
 			if (err) {
-				pr_err("Failed to re-register event %u: %d\n",
+				pr_err("Failed to re-register event 0x%x: %d\n",
 				       event->event_num, err);
 			}
 		}
@@ -701,7 +701,7 @@ static int sdei_cpuhp_up(unsigned int cpu)
 		if (event->reenable) {
 			err = sdei_do_local_call(_local_event_enable, event);
 			if (err) {
-				pr_err("Failed to re-enable event %u: %d\n",
+				pr_err("Failed to re-enable event 0x%x: %d\n",
 				       event->event_num, err);
 			}
 		}
@@ -1095,7 +1095,7 @@ int sdei_event_handler(struct pt_regs *regs,
 
 	err = arg->callback(event_num, regs, arg->callback_arg);
 	if (err)
-		pr_err_ratelimited("event %u on CPU %u failed with error: %d\n",
+		pr_err_ratelimited("event 0x%x on CPU 0x%x failed with error: %d\n",
 				   event_num, smp_processor_id(), err);
 
 	return err;
-- 
2.17.1