linux-kernel - Re: [GIT PULL] tracing: Fixes and clean ups for v5.14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210812133306.1c480741@oasis.local.home>
Date:   Thu, 12 Aug 2021 13:33:06 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Daniel Bristot de Oliveira <bristot@...nel.org>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [GIT PULL] tracing: Fixes and clean ups for v5.14

On Thu, 12 Aug 2021 07:18:37 -1000
Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Thu, Aug 12, 2021 at 5:29 AM Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> > - Fix warning for use of "main" variable in osnoise tracer  
> 
> Honestly, I refuse to pull this kind of inexplicable garbage.

That was my take too, when this was first addressed:

  https://lore.kernel.org/lkml/20210730204050.46975ae2@oasis.local.home/

> 
> The commit message talks about "some compilers/analyzers" without any
> explanation, and the "Link:" thing doesn't link to anything useful
> either.

I should have added the above link. :-/

Where the link in this commit was simply added by my scripts.

> 
> Those compilers/analyzers are clearly complete and utter crap, and my
> reaction is that I want a *lot* more explanation why we should care
> about other peoples crap.

I totally agree.

> 
> I do NOT want to see people caring about warnings that make no sense,
> certainly not without extensive explanations about why we should care
> about broken tools.
> 
> Fix the tool. Add a "--Wno-warn-about-stupid-issues" flag to the tool
> usage. Don't make pointless changes to the kernel to work around other
> peoples garbage.

:-) :-) :-)

I'm totally happy with this approach. I took the lazy method, and let
them change the variable.

But I'm 100% on your side of the issue. I HATE these stupid warnings.

I swear, these warnings are the gcc equivalent of spelling fixes to the
kernel. "Oh, I can get a patch into gcc via adding a new useless
warning!"

I'll drop the patch, and send you a v2.

-- Steve