linux-kernel - Re: [PATCH v2 3/3] mm/gup: Remove try_get_page(), call try_get_compound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bf6d220-1126-97a6-c7cc-3c198612c5c2@nvidia.com>
Date:   Thu, 12 Aug 2021 11:19:01 -0700
From:   John Hubbard <jhubbard@...dia.com>
To:     Christoph Hellwig <hch@....de>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        LKML <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        <linux-s390@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
        Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH v2 3/3] mm/gup: Remove try_get_page(), call
 try_get_compound_head() directly

On 8/12/21 2:22 AM, Christoph Hellwig wrote:
> On Wed, Aug 11, 2021 at 12:05:42AM -0700, John Hubbard wrote:
>> -		if (unlikely(!try_get_page(page)))
>> +		if (unlikely(try_get_compound_head(page, 1) == NULL))
> 
> Why not a simple ! instead of the == NULL?

I'll fix those up and post a v4.

> 
> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> 

Thanks for the reviews!


thanks,
-- 
John Hubbard
NVIDIA