linux-kernel - Re: [RFC PATCH v2 2/5] mm: Remove the callback func argument from __swap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210813070334.GB26339@lst.de>
Date:   Fri, 13 Aug 2021 09:03:34 +0200
From:   Christoph Hellwig <hch@....de>
To:     David Howells <dhowells@...hat.com>
Cc:     willy@...radead.org, Seth Jennings <sjenning@...ux.vnet.ibm.com>,
        Bob Liu <bob.liu@...cle.com>, Minchan Kim <minchan@...nel.org>,
        Dan Magenheimer <dan.magenheimer@...cle.com>,
        trond.myklebust@...marydata.com, darrick.wong@...cle.com,
        hch@....de, viro@...iv.linux.org.uk, jlayton@...nel.org,
        sfrench@...ba.org, torvalds@...ux-foundation.org,
        linux-nfs@...r.kernel.org, linux-mm@...ck.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v2 2/5] mm: Remove the callback func argument from
 __swap_writepage()

On Thu, Aug 12, 2021 at 09:22:15PM +0100, David Howells wrote:
> Remove the callback func argument from __swap_writepage() as it's
> end_swap_bio_write() in both places that call it.

Yeah.  I actually had a similar patch in a WIP tree for a while but
never got to end it out.

>  /* linux/mm/page_io.c */
>  extern int swap_readpage(struct page *page, bool do_poll);
>  extern int swap_writepage(struct page *page, struct writeback_control *wbc);
> -extern void end_swap_bio_write(struct bio *bio);
> -extern int __swap_writepage(struct page *page, struct writeback_control *wbc,
> -	bio_end_io_t end_write_func);
> +extern int __swap_writepage(struct page *page, struct writeback_control *wbc);

Please also drop the extern while you're at it.

With that:

Reviewed-by: Christoph Hellwig <hch@....de>