linux-kernel - RE: drivers/net/wireless/mediatek/mt76/mt7915/init.c:134:41: warning: passing argument 1 of 'thermal_cooling_device_register' discards 'const' qualifier from pointer target type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PS1PR03MB49083C10BECCC3F16D41980291FA9@PS1PR03MB4908.apcprd03.prod.outlook.com>
Date:   Fri, 13 Aug 2021 08:42:28 +0000
From:   Ryder Lee (李庚諺) <Ryder.Lee@...iatek.com>
To:     kernel test robot <lkp@...el.com>
CC:     "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Felix Fietkau <nbd@....name>
Subject: RE: drivers/net/wireless/mediatek/mt76/mt7915/init.c:134:41: warning:
 passing argument 1 of 'thermal_cooling_device_register' discards 'const'
 qualifier from pointer target type


The cause is https://lore.kernel.org/lkml/ABDAFCAB-8DF5-41A7-B1E0-4953A9BF32B3@gmail.com/T/


-----Original Message-----
From: kernel test robot [mailto:lkp@...el.com] 
Sent: Friday, August 13, 2021 12:20 AM
To: Ryder Lee <Ryder.Lee@...iatek.com>
Cc: kbuild-all@...ts.01.org; linux-kernel@...r.kernel.org; Felix Fietkau <nbd@....name>
Subject: drivers/net/wireless/mediatek/mt76/mt7915/init.c:134:41: warning: passing argument 1 of 'thermal_cooling_device_register' discards 'const' qualifier from pointer target type

Hi Ryder,

FYI, the error/warning still remains.

tree:   https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git__;!!CTRNKA9wMg0ARbw!1yGhyZ2zcgDSAZInyFCpTWQq7wm0KK7MwoYWKEME_DrayfcYfxh4i9dnufVN9C-c$  master
head:   f8e6dfc64f6135d1b6c5215c14cd30b9b60a0008
commit: 34b877d972bec8cbf397a57393317672cf92996f mt76: mt7915: add thermal cooling device support
date:   8 weeks ago
config: x86_64-buildonly-randconfig-r001-20210812 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=34b877d972bec8cbf397a57393317672cf92996f__;!!CTRNKA9wMg0ARbw!1yGhyZ2zcgDSAZInyFCpTWQq7wm0KK7MwoYWKEME_DrayfcYfxh4i9dnueYlmjdK$ 
        git remote add linus https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git__;!!CTRNKA9wMg0ARbw!1yGhyZ2zcgDSAZInyFCpTWQq7wm0KK7MwoYWKEME_DrayfcYfxh4i9dnufVN9C-c$ 
        git fetch --no-tags linus master
        git checkout 34b877d972bec8cbf397a57393317672cf92996f
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/wireless/mediatek/mt76/mt7915/init.c: In function 'mt7915_thermal_init':
>> drivers/net/wireless/mediatek/mt76/mt7915/init.c:134:41: warning: 
>> passing argument 1 of 'thermal_cooling_device_register' discards 
>> 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     134 |  cdev = thermal_cooling_device_register(wiphy_name(wiphy), phy,
         |                                         ^~~~~~~~~~~~~~~~~
   In file included from drivers/net/wireless/mediatek/mt76/mt7915/init.c:7:
   include/linux/thermal.h:407:39: note: expected 'char *' but argument is of type 'const char *'
     407 | thermal_cooling_device_register(char *type, void *devdata,
         |                                 ~~~~~~^~~~


vim +134 drivers/net/wireless/mediatek/mt76/mt7915/init.c

   127	
   128	static int mt7915_thermal_init(struct mt7915_phy *phy)
   129	{
   130		struct wiphy *wiphy = phy->mt76->hw->wiphy;
   131		struct thermal_cooling_device *cdev;
   132		struct device *hwmon;
   133	
 > 134		cdev = thermal_cooling_device_register(wiphy_name(wiphy), phy,
   135						       &mt7915_thermal_ops);
   136		if (!IS_ERR(cdev)) {
   137			if (sysfs_create_link(&wiphy->dev.kobj, &cdev->device.kobj,
   138					      "cooling_device") < 0)
   139				thermal_cooling_device_unregister(cdev);
   140			else
   141				phy->cdev = cdev;
   142		}
   143	
   144		if (!IS_REACHABLE(CONFIG_HWMON))
   145			return 0;
   146	
   147		hwmon = devm_hwmon_device_register_with_groups(&wiphy->dev,
   148							       wiphy_name(wiphy), phy,
   149							       mt7915_hwmon_groups);
   150		if (IS_ERR(hwmon))
   151			return PTR_ERR(hwmon);
   152	
   153		return 0;
   154	}
   155	

---
0-DAY CI Kernel Test Service, Intel Corporation https://urldefense.com/v3/__https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org__;!!CTRNKA9wMg0ARbw!1yGhyZ2zcgDSAZInyFCpTWQq7wm0KK7MwoYWKEME_DrayfcYfxh4i9dnuV9Db3hd$