linux-kernel - Re: [PATCH] RDMA/rxe: Remove duplicate umem assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Aug 2021 11:30:17 +0000
From:   "yangx.jy@...itsu.com" <yangx.jy@...itsu.com>
To:     Shunsuke Mie <mie@...l.co.jp>
CC:     Zhu Yanjun <zyjzyj2000@...il.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] RDMA/rxe: Remove duplicate umem assignment

Hi,

My same fix[1] has been merged into for-next branch on rdma but it is
not merged into mainline for now.

[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?id=cdbdb7724740f62d11519679e11cf673cd9d6c8f

Best Regards,
Xiao Yang

On 2021/8/13 13:57, Shunsuke Mie wrote:
> While initialization of rxe_mr, mr->umem is assigned duplicate. Remove
> the redundant code.
>
> Signed-off-by: Shunsuke Mie <mie@...l.co.jp>
> ---
>  drivers/infiniband/sw/rxe/rxe_mr.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
> index 73bbafd32554..6e2e0da2e50d 100644
> --- a/drivers/infiniband/sw/rxe/rxe_mr.c
> +++ b/drivers/infiniband/sw/rxe/rxe_mr.c
> @@ -122,7 +122,6 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
>  		goto err1;
>  	}
>  
> -	mr->umem = umem;
>  	num_buf = ib_umem_num_pages(umem);
>  
>  	rxe_mr_init(access, mr);