linux-kernel - Re: [PATCH V2 1/3] perf/x86: Add new event for AUX output counter index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52e21dcc-3b0d-3c87-deb4-18ead45fed24@intel.com>
Date:   Fri, 13 Aug 2021 15:17:14 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>, Leo Yan <leo.yan@...aro.org>,
        Kan Liang <kan.liang@...ux.intel.com>, x86@...nel.org,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/3] perf/x86: Add new event for AUX output counter
 index

On 5/07/21 10:24 am, Peter Zijlstra wrote:
> On Thu, Jul 01, 2021 at 04:17:30PM +0300, Adrian Hunter wrote:
>> diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
>> index e28892270c58..7a7c3b18acec 100644
>> --- a/arch/x86/events/intel/core.c
>> +++ b/arch/x86/events/intel/core.c
>> @@ -2400,6 +2400,12 @@ static void intel_pmu_disable_event(struct perf_event *event)
>>  		intel_pmu_pebs_disable(event);
>>  }
>>  
>> +static void intel_pmu_assign_event(struct perf_event *event, int idx)
>> +{
>> +	if (is_pebs_pt(event))
>> +		perf_report_aux_output_id(event, idx);
>> +}
>> +
>>  static void intel_pmu_del_event(struct perf_event *event)
>>  {
>>  	if (needs_branch_stack(event))
>> @@ -4596,6 +4602,7 @@ static __initconst const struct x86_pmu intel_pmu = {
>>  	.enable_all		= intel_pmu_enable_all,
>>  	.enable			= intel_pmu_enable_event,
>>  	.disable		= intel_pmu_disable_event,
>> +	.assign			= intel_pmu_assign_event,
>>  	.add			= intel_pmu_add_event,
>>  	.del			= intel_pmu_del_event,
>>  	.read			= intel_pmu_read_event,
> 
> How about we only set that method (or clear it again) when
> intel_cap.pebs_output_pt_available ?

I've finally got back to this, but now, in the case of hybrids,
there seems to be more than one intel_cap.pebs_output_pt_available.
Any suggestions?

> 
> Other than that, this looks good to me.
>