linux-kernel - Re: [PATCH] POWER SUPPLY CLASS/SUBSYSTEM : add new status 'Full charging' can show that the battery is fully charged but still charging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210813163454.de6rprklvnbnq3yv@earth.universe>
Date:   Fri, 13 Aug 2021 18:34:54 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     zhuguanghong <zhuguanghong@...ontech.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] POWER SUPPLY CLASS/SUBSYSTEM : add new status 'Full
 charging' can show that the battery is fully charged but still charging

Hi,

On Wed, Jul 07, 2021 at 04:17:51PM +0800, zhuguanghong wrote:

Where is the long description?

Why is this needed? If userspace wants to know the details
(trickle charging vs small leak battery usage) it can always
check current_now / power_now. I think adding this will make
things more complex without any real improvement.

> Signed-off-by: zhuguanghong <zhuguanghong@...ontech.com>
> ---


>  drivers/power/supply/power_supply_sysfs.c | 1 +
>  include/linux/power_supply.h              | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> index c3d7cbcd4fad..0ddb84b7637f 100644
> --- a/drivers/power/supply/power_supply_sysfs.c
> +++ b/drivers/power/supply/power_supply_sysfs.c
> @@ -78,6 +78,7 @@ static const char * const POWER_SUPPLY_STATUS_TEXT[] = {
>  	[POWER_SUPPLY_STATUS_DISCHARGING]	= "Discharging",
>  	[POWER_SUPPLY_STATUS_NOT_CHARGING]	= "Not charging",
>  	[POWER_SUPPLY_STATUS_FULL]		= "Full",
> +	[POWER_SUPPLY_STATUS_FULL_CHARGING]	= "Full charging",
>  };
>  
>  static const char * const POWER_SUPPLY_CHARGE_TYPE_TEXT[] = {
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index be203985ecdd..04844dbb18c4 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -37,6 +37,7 @@ enum {
>  	POWER_SUPPLY_STATUS_DISCHARGING,
>  	POWER_SUPPLY_STATUS_NOT_CHARGING,
>  	POWER_SUPPLY_STATUS_FULL,
> +	POWER_SUPPLY_STATUS_FULL_CHARGING,
>  };
>  
>  /* What algorithm is the charger using? */
> -- 
> 2.20.1
> 
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)