linux-kernel - Re: [PATCH v14 035/138] mm/memcg: Use the node id in mem_cgroup_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YRbAbHraZjY1dwSG@casper.infradead.org>
Date:   Fri, 13 Aug 2021 19:56:44 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     David Howells <dhowells@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-fsdevel@...r.kernel.org, Michal Hocko <mhocko@...e.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v14 035/138] mm/memcg: Use the node id in
 mem_cgroup_update_tree()

On Tue, Aug 10, 2021 at 09:06:52PM +0100, David Howells wrote:
> Matthew Wilcox (Oracle) <willy@...radead.org> wrote:
> 
> > By using the node id in mem_cgroup_update_tree(), we can delete
> > soft_limit_tree_from_page() and mem_cgroup_page_nodeinfo().  Saves 42
> > bytes of kernel text on my config.
> > 
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> > Acked-by: Michal Hocko <mhocko@...e.com>
> > Acked-by: Johannes Weiner <hannes@...xchg.org>
> > Reviewed-by: Christoph Hellwig <hch@....de>
> 
> Reviewed-by: David Howells <dhowells@...hat.com>
> 
> Though I wonder if:
> 
> > -		mz = mem_cgroup_page_nodeinfo(memcg, page);
> > +		mz = memcg->nodeinfo[nid];
> 
> should still have some sort of wrapper function.

I was asked to remove the wrapper function as it didn't provide enough
utility to warrant the indirection.