linux-kernel - Re: [PATCH v9 14/26] x86/arch_prctl: Create ARCH_SET_STATE_ENABLE/ARCH_GET_STATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B04AD498-8EE3-4D60-8AF1-CF6ED1D6E55C@intel.com>
Date:   Fri, 13 Aug 2021 19:44:01 +0000
From:   "Bae, Chang Seok" <chang.seok.bae@...el.com>
To:     "Macieira, Thiago" <thiago.macieira@...el.com>
CC:     "bp@...e.de" <bp@...e.de>, "Lutomirski, Andy" <luto@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...nel.org" <mingo@...nel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "Brown, Len" <len.brown@...el.com>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        "Liu, Jing2" <jing2.liu@...el.com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v9 14/26] x86/arch_prctl: Create
 ARCH_SET_STATE_ENABLE/ARCH_GET_STATE_ENABLE

On Aug 9, 2021, at 17:57, Bae, Chang Seok <chang.seok.bae@...el.com> wrote:
> On Aug 9, 2021, at 16:42, Macieira, Thiago <thiago.macieira@...el.com> wrote:
>> 
>> This means the corruption can get worse since the rollback code can undo or 
>> partially undo the progression of the other ARCH_SET_STATE_ENABLE.
> 
> Maybe something like this can help here to ensure a valid rollback.

After reconsidering this, I think the group_leader task’s permission value is
reliable. Perhaps, reference group_leader’s everywhere, instead of each
task's. I think that way resolves the corner case in a simple way.

Thanks,
Chang