linux-kernel - Re: Re: [PATCH bpf-next v6 0/5] sockmap: add sockmap support for unix stream socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP_N_Z8Czh-hiKn3AwWb-Yib30805BOnVcY8urd=-2mVDctsjg@mail.gmail.com>
Date:   Fri, 13 Aug 2021 21:31:17 -0700
From:   "Jiang Wang ." <jiang.wang@...edance.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Networking <netdev@...r.kernel.org>,
        Cong Wang <cong.wang@...edance.com>,
        Xiongchun Duan <duanxiongchun@...edance.com>,
        Yongji Xie <xieyongji@...edance.com>,
        柴稳 <chaiwen.cc@...edance.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jakub Sitnicki <jakub@...udflare.com>,
        Lorenz Bauer <lmb@...udflare.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        KP Singh <kpsingh@...nel.org>, Shuah Khan <shuah@...nel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Johan Almbladh <johan.almbladh@...finetworks.com>,
        open list <linux-kernel@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>
Subject: Re: Re: [PATCH bpf-next v6 0/5] sockmap: add sockmap support for unix
 stream socket

On Fri, Aug 13, 2021 at 3:42 PM Andrii Nakryiko
<andrii.nakryiko@...il.com> wrote:
>
> On Mon, Aug 9, 2021 at 12:47 PM Jiang Wang <jiang.wang@...edance.com> wrote:
> >
> > This patch series add support for unix stream type
> > for sockmap. Sockmap already supports TCP, UDP,
> > unix dgram types. The unix stream support is similar
> > to unix dgram.
> >
> > Also add selftests for unix stream type in sockmap tests.
> >
>
> Hey Jiang,
>
> This patch doesn't apply cleanly to bpf-next anymore ([0]), can you
> please rebase and resubmit, adding John's and Jakub's acks along the
> way? Thanks!
>

Sure, I just rebased, added ack and sent the patch again with the same title.
Let me know if there is any problem. Thanks.


>   [0] https://github.com/kernel-patches/bpf/pull/1563#issuecomment-896128082
>
> >
> > Jiang Wang (5):
> >   af_unix: add read_sock for stream socket types
> >   af_unix: add unix_stream_proto for sockmap
> >   selftest/bpf: add tests for sockmap with unix stream type.
> >   selftest/bpf: change udp to inet in some function names
> >   selftest/bpf: add new tests in sockmap for unix stream to tcp.
> >
> >  include/net/af_unix.h                         |  8 +-
> >  net/unix/af_unix.c                            | 91 +++++++++++++++---
> >  net/unix/unix_bpf.c                           | 93 ++++++++++++++-----
> >  .../selftests/bpf/prog_tests/sockmap_listen.c | 48 ++++++----
> >  4 files changed, 187 insertions(+), 53 deletions(-)
> >
> > v1 -> v2 :
> >  - Call unhash in shutdown.
> >  - Clean up unix_create1 a bit.
> >  - Return -ENOTCONN if socket is not connected.
> >
> > v2 -> v3 :
> >  - check for stream type in update_proto
> >  - remove intermediate variable in __unix_stream_recvmsg
> >  - fix compile warning in unix_stream_recvmsg
> >
> > v3 -> v4 :
> >  - remove sk_is_unix_stream, just check TCP_ESTABLISHED for UNIX sockets.
> >  - add READ_ONCE in unix_dgram_recvmsg
> >  - remove type check in unix_stream_bpf_update_proto
> >
> > v4 -> v5 :
> >  - add two missing READ_ONCE for sk_prot.
> >
> > v5 -> v6 :
> >  - fix READ_ONCE by reading to a local variable first.
> >
> > --
> > 2.20.1
> >