linux-kernel - Re: [PATCH] PCI/MSI: Clarify the irq sysfs ABI for PCI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YRd90p6Kcxpq6cbp@kroah.com>
Date:   Sat, 14 Aug 2021 10:24:50 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Barry Song <21cnbao@...il.com>
Cc:     bhelgaas@...gle.com, corbet@....net, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org, mchehab+huawei@...nel.org,
        Jonathan.Cameron@...wei.com, leon@...nel.org,
        schnelle@...ux.ibm.com, bilbao@...edu, luzmaximilian@...il.com,
        linuxarm@...wei.com, Barry Song <song.bao.hua@...ilicon.com>
Subject: Re: [PATCH] PCI/MSI: Clarify the irq sysfs ABI for PCI devices

On Sat, Aug 14, 2021 at 12:26:50AM +1200, Barry Song wrote:
> From: Barry Song <song.bao.hua@...ilicon.com>
> 
> /sys/bus/pci/devices/.../irq has been there for many years but it has never
> been documented. This patch is trying to document it. Plus, irq ABI is very
> confusing at this moment especially for MSI and MSI-x cases. MSI sets irq
> to the first number in the vector, but MSI-X does nothing for this though
> it saves default_irq in msix_setup_entries(). Weird the saved default_irq
> for MSI-X is never used in pci_msix_shutdown(), which is quite different
> with pci_msi_shutdown(). Thus, this patch also moves to show the first IRQ
> number which is from the first msi_entry for MSI-X. Hopefully, this can
> make irq ABI more clear and more consistent.
> 
> Signed-off-by: Barry Song <song.bao.hua@...ilicon.com>
> ---
>  Documentation/ABI/testing/sysfs-bus-pci | 8 ++++++++
>  drivers/pci/msi.c                       | 6 ++++++
>  2 files changed, 14 insertions(+)

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>