linux-kernel - [PATCH linux-next] dio: add iounmap when ioremap() is called.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210814093718.105825-1-xu.xin16@zte.com.cn>
Date:   Sat, 14 Aug 2021 02:37:18 -0700
From:   cgel.zte@...il.com
To:     linux-kernel@...r.kernel.org
Cc:     xu.xin16@....com.cn, Zeal Robot <zealci@....com.cn>
Subject: [PATCH linux-next] dio: add iounmap when ioremap() is called.

From: xu_xin <xu.xin16@....com.cn>

In __init dio_ini(void), when kzalloc() fails, we add the operation of
iounmap because ioremap is probably called in line 210.:

Reported-by: Zeal Robot<zealci@....com.cn>
Signed-off-by: xu_xin <xu.xin16@....com.cn>
---
 drivers/dio/dio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dio/dio.c b/drivers/dio/dio.c
index b2ff5ff84b80..21bdb16dc2f3 100644
--- a/drivers/dio/dio.c
+++ b/drivers/dio/dio.c
@@ -218,8 +218,8 @@ static int __init dio_init(void)

                 /* Found a board, allocate it an entry in the list */
 		dev = kzalloc(sizeof(struct dio_dev), GFP_KERNEL);
-		if (!dev){
-			if(scode >= DIOII_SCBASE)
+		if (!dev) {
+			if (scode >= DIOII_SCBASE)
 				iounmap(va);
 			return 0;
 		}
-- 
2.25.1