linux-kernel - Re: [RESEND PATCH V3] genirq/affinity: add helper of irq_affinity_calc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 14 Aug 2021 19:35:13 +0800
From:   Ming Lei <ming.lei@...hat.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     linux-kernel@...r.kernel.org, Bjorn Helgaas <helgaas@...nel.org>,
        Christoph Hellwig <hch@....de>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org
Subject: Re: [RESEND PATCH V3] genirq/affinity: add helper of
 irq_affinity_calc_sets

On Fri, Aug 06, 2021 at 04:19:37PM +0800, Ming Lei wrote:
> When driver requests to allocate irq affinity managed vectors,
> pci_alloc_irq_vectors_affinity() may fallback to single vector
> allocation. In this situation, we don't need to call
> irq_create_affinity_masks for calling into ->calc_sets() for
> avoiding potential memory leak, so add the helper for this purpose.
> 
> Fixes: c66d4bd110a1 ("genirq/affinity: Add new callback for (re)calculating interrupt sets")
> Reported-by: Bjorn Helgaas <helgaas@...nel.org>
> Reviewed-by: Christoph Hellwig <hch@....de>
> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: linux-pci@...r.kernel.org
> Signed-off-by: Ming Lei <ming.lei@...hat.com>
> ---
> V3:
> 	- avoid pointless negations
> V2:
> 	- move WARN_ON_ONCE() into irq_affinity_calc_sets
> 	- don't install default calc_sets() callback as suggested by
> 	Christoph

Hello Thomas,

Can you take a look at this patch?

Thanks, 
Ming