linux-kernel - Re: [PATCH] watchdog: stm32_iwdg: drop superfluous error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <500cc974-bc39-74d5-1e1c-f763e25caa8b@roeck-us.net>
Date:   Sat, 14 Aug 2021 08:02:25 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Tang Bin <tangbin@...s.chinamobile.com>, wim@...ux-watchdog.org,
        mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com
Cc:     linux-watchdog@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Zhang Shengju <zhangshengju@...s.chinamobile.com>
Subject: Re: [PATCH] watchdog: stm32_iwdg: drop superfluous error message

On 8/14/21 7:27 AM, Tang Bin wrote:
> In the function stm32_iwdg_probe(), devm_platform_ioremap_resource
> has already contained error message, so drop the redundant one.
> 
> Co-developed-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/stm32_iwdg.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c
> index a3436c296..570a71509 100644
> --- a/drivers/watchdog/stm32_iwdg.c
> +++ b/drivers/watchdog/stm32_iwdg.c
> @@ -237,10 +237,8 @@ static int stm32_iwdg_probe(struct platform_device *pdev)
>   
>   	/* This is the timer base. */
>   	wdt->regs = devm_platform_ioremap_resource(pdev, 0);
> -	if (IS_ERR(wdt->regs)) {
> -		dev_err(dev, "Could not get resource\n");
> +	if (IS_ERR(wdt->regs))
>   		return PTR_ERR(wdt->regs);
> -	}
>   
>   	ret = stm32_iwdg_clk_init(pdev, wdt);
>   	if (ret)
>