linux-kernel - Re: [PATCH] staging: r8188eu: os_dep: Remove defined but not used variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0c701f3-d13e-421a-c22b-d6be98e28e97@gmail.com>
Date:   Sat, 14 Aug 2021 19:01:56 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Martin Kaiser <martin@...ser.cx>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: os_dep: Remove defined but not used
 variables

On 8/14/21 6:08 PM, Fabio M. De Francesco wrote:
> Remove defined but not used const variables. Issues detected by GCC
> running with -Wunused-const-variable option enabled.
> 
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com>
> ---
>   drivers/staging/r8188eu/os_dep/ioctl_linux.c | 21 --------------------
>   1 file changed, 21 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> index 38ee41f9d2ba..d9fdd83218dc 100644
> --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> @@ -84,11 +84,6 @@ static u32 rtw_rates[] = {1000000, 2000000, 5500000, 11000000,
>   	6000000, 9000000, 12000000, 18000000, 24000000, 36000000,
>   	48000000, 54000000};
>   
> -static const char * const iw_operation_mode[] = {
> -	"Auto", "Ad-Hoc", "Managed",  "Master", "Repeater",
> -	"Secondary", "Monitor"
> -};
> -
>   void indicate_wx_scan_complete_event(struct adapter *padapter)
>   {
>   	union iwreq_data wrqu;
> @@ -6666,19 +6661,3 @@ struct iw_handler_def rtw_handlers_def = {
>   	.num_private_args = sizeof(rtw_private_args) / sizeof(struct iw_priv_args),
>   	.get_wireless_stats = rtw_get_wireless_stats,
>   };
> -
> -/*  copy from net/wireless/wext.c start */
> -/* ---------------------------------------------------------------- */
> -/*
> - * Calculate size of private arguments
> - */
> -static const char iw_priv_type_size[] = {
> -	0,			      /* IW_PRIV_TYPE_NONE */
> -	1,			      /* IW_PRIV_TYPE_BYTE */
> -	1,			      /* IW_PRIV_TYPE_CHAR */
> -	0,			      /* Not defined */
> -	sizeof(__u32),		  /* IW_PRIV_TYPE_INT */
> -	sizeof(struct iw_freq),	 /* IW_PRIV_TYPE_FLOAT */
> -	sizeof(struct sockaddr),	/* IW_PRIV_TYPE_ADDR */
> -	0,			      /* Not defined */
> -};
> 

Looks good to me, thanks.

Acked-by: Michael Straube <straube.linux@...il.com>

Michael