linux-kernel - Re:Re: [PATCH v5 1/2] f2fs: introduce proc/fs/f2fs/<dev>/fsck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AEMABgAWDwhd8*f2P*fotqoY.3.1628906905520.Hmail.frank.li@vivo.com>
Date:   Sat, 14 Aug 2021 10:08:25 +0800 (GMT+08:00)
From:   李扬韬 <frank.li@...o.com>
To:     Chao Yu <chao@...nel.org>
Cc:     jaegeuk@...nel.org, linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re:Re: [PATCH v5 1/2] f2fs: introduce proc/fs/f2fs/<dev>/fsck_stack node

>> We can't remove stack from depot, as we store them contiguously one after
>> another in a contiguous memory allocation.
>> 
>> Or we can limit the recorded stack number.
>> 
>> $ grep -nr "SBI_NEED_FSCK" fs/f2fs/ --include=*.c --include=*.h | wc -l
>> 53
>> $ grep -nr "f2fs_bug_on" fs/f2fs/ --include=*.c --include=*.h | wc -l
>> 135
>
>I didn't look into details of stack_depot_save(), two stack handles from below
>call paths will be the same?
>
>- move_data_block
>  - f2fs_wait_on_page_writeback
>   - f2fs_bug_on
>
>- ra_data_block
>  - f2fs_wait_on_page_writeback
>   - f2fs_bug_on
>
>If they have different stack handles, combination number of
>set_sbi_flag(NEED_FSCK)/f2fs_bug_on and their callers will be far more than two
>hundred.
>

Yes, these will be two different stacks. In the most extreme case, there will be 1000 (I guess) different places to set fsck?
Or we limit the number of recorded stacks to 10?
what do you think. The stack depot design does not consider removing the stack from the depot.

MBR,
Yangtao