[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210815144007.3e7cwiecbre2nt6y@two.firstfloor.org>
Date: Sun, 15 Aug 2021 07:40:10 -0700
From: Andi Kleen <andi@...stfloor.org>
To: Claire Jensen <cjense@...gle.com>
Cc: peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
mark.rutland@....com, alexander.shishkin@...ux.intel.com,
jolsa@...hat.com, namhyung@...nel.org, yao.jin@...ux.intel.com,
song@...nel.org, andi@...stfloor.org, adrian.hunter@...el.com,
kan.liang@...ux.intel.com, james.clark@....com,
alexander.antonov@...ux.intel.com, changbin.du@...el.com,
liuqi115@...wei.com, irogers@...gle.com, eranian@...gle.com,
linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
clairej735@...il.com
Subject: Re: [PATCH v2 1/1] perf stat: Add JSON output option.
> CSV output example:
>
> 1.20,msec,task-clock:u,1204272,100.00,0.697,CPUs utilized
> 0,,context-switches:u,1204272,100.00,0.000,/sec
> 0,,cpu-migrations:u,1204272,100.00,0.000,/sec
> 70,,page-faults:u,1204272,100.00,58.126,K/sec
The difficult part of such changes to perf stat is that it has
so many different output modes that all need to be tested.
Unfortunately the unit tests in perf test are not really
enough for it.
I have an older script (attached) that tests a lot of these outputs. It just
exercises them, you still need to check the output manually
Can you check that all these modes work correctly both
with and without json?
-Andi
View attachment "STAT-REGR-TEST" of type "text/plain" (766 bytes)
Powered by blists - more mailing lists