linux-kernel - Re: [PATCH] Makefile: use -Wno-main in the full kernel tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Aug 2021 11:08:55 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Daniel Bristot de Oliveira <bristot@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] Makefile: use -Wno-main in the full kernel tree

On Fri, 13 Aug 2021 15:41:31 -0700
Randy Dunlap <rdunlap@...radead.org> wrote:

> When using gcc (SUSE Linux) 7.5.0 (on openSUSE 15.3), I see a
> build warning:
> 
> ../kernel/trace/trace_osnoise.c: In function 'start_kthread':
> ../kernel/trace/trace_osnoise.c:1461:8: warning: 'main' is usually a function [-Wmain]
>   void *main = osnoise_main;
>         ^~~~
> 
> Quieten that warning by using "-Wno-main". It's OK to use "main" as a
> declaration name in the kernel.
> 
> Build-tested on most ARCHes.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Suggested-by: Steven Rostedt <rostedt@...dmis.org>
> Suggested-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Daniel Bristot de Oliveira <bristot@...nel.org>
> Cc: Masahiro Yamada <masahiroy@...nel.org>
> Cc: Michal Marek <michal.lkml@...kovi.net>
> Cc: linux-kbuild@...r.kernel.org
> ---
>  Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20210812.orig/Makefile
> +++ linux-next-20210812/Makefile
> @@ -522,7 +522,7 @@ KBUILD_AFLAGS   := -D__ASSEMBLY__ -fno-P
>  KBUILD_CFLAGS   := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
>  		   -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE \
>  		   -Werror=implicit-function-declaration -Werror=implicit-int \
> -		   -Werror=return-type -Wno-format-security \
> +		   -Werror=return-type -Wno-format-security -Wno-main \

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

>  		   -std=gnu89
>  KBUILD_CPPFLAGS := -D__KERNEL__
>  KBUILD_RUST_TARGET := $(srctree)/arch/$(SRCARCH)/rust/target.json