linux-kernel - Re: [PATCH -next] cpufreq: remove useless INIT_LIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20210816035644.b5y45yldxsi6nrgh@vireshk-i7>
Date:   Mon, 16 Aug 2021 09:26:44 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Han Wang <zjuwanghan@...look.com>, ionela.voinescu@....com
Cc:     "Rafael J . Wysocki" <rjw@...ysocki.net>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] cpufreq: remove useless INIT_LIST_HEAD()

+Ionela who added this.

On 15-08-21, 21:07, Han Wang wrote:
> list cpu_data_list has been inited staticly through LIST_HEAD,
> so there's no need to call another INIT_LIST_HEAD. Simply remove
> it from cppc_cpufreq_init.
> 
> Signed-off-by: Han Wang <zjuwanghan@...look.com>
> ---
>  drivers/cpufreq/cppc_cpufreq.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index d4c27022b..db1719626 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -741,8 +741,6 @@ static int __init cppc_cpufreq_init(void)
>  	if ((acpi_disabled) || !acpi_cpc_valid())
>  		return -ENODEV;
>  
> -	INIT_LIST_HEAD(&cpu_data_list);
> -
>  	cppc_check_hisi_workaround();
>  	cppc_freq_invariance_init();
>  
> -- 
> 2.25.1

-- 
viresh