linux-kernel - Re: [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YRnmRp92j7Qpir7N@lunn.ch>
Date:   Mon, 16 Aug 2021 06:15:02 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     "Song, Yoong Siang" <yoong.siang.song@...el.com>
Cc:     Russell King <linux@...linux.org.uk>,
        Marek Behún <kabel@...nel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE_PHY support
 to WOL event

On Mon, Aug 16, 2021 at 03:52:06AM +0000, Song, Yoong Siang wrote:
> > > Agreed. If the interrupt register is being used, i think we need this
> > > patchset to add proper interrupt support. Can you recommend a board
> > > they can buy off the shelf with the interrupt wired up? Or maybe Intel
> > > can find a hardware engineer to add a patch wire to link the interrupt
> > > output to a SoC pin that can do interrupts.
> > 
> > The only board I'm aware of with the 88x3310 interrupt wired is the
> > Macchiatobin double-shot. :)
> > 
> > I forget why I didn't implement interrupt support though - I probably need to
> > revisit that. Sure enough, looking at the code I was tinkering with, adding
> > interrupt support would certainly conflict with this patch.
> 
> Hi Russell,
> 
> For EHL board, both WoL interrupt and link change interrupt are the same pin.
> Based on your knowledge, is this common across other platforms?

Other PHYs? Yes. WoL is just another interrupt, and any interrupt can
wake the system, so longer as the interrupt controller can actually wake the system.

> Can we take set wol function as one of the ways to control the
> interrupts?

WOl does not control the interrupt, it is an interrupt source. And you
need to service it as an interrupt. So long as your PMC is also an
interrupt controller, it should all work.

	  Andrew