linux-kernel - Re: [PATCH] media: mtk-mdp: make mtk_mdp_comp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <484e199d23a09d79f121ea37eb9e7d95eabfd886.camel@mediatek.com>
Date:   Mon, 16 Aug 2021 12:26:07 +0800
From:   houlong wei <houlong.wei@...iatek.com>
To:     Eizan Miyamoto <eizan@...omium.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "enric.balletbo@...labora.com" <enric.balletbo@...labora.com>,
        "dafna.hirschfeld@...labora.com" <dafna.hirschfeld@...labora.com>,
        "Andrew-CT Chen (陳智迪)" 
        <Andrew-CT.Chen@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "Minghsiu Tsai (蔡明修)" 
        <Minghsiu.Tsai@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>, <houlong.wei@...iatek.com>
Subject: Re: [PATCH] media: mtk-mdp: make mtk_mdp_comp_init static

On Wed, 2021-08-11 at 15:15 +0800, Eizan Miyamoto wrote:
> This function isn't and doesn't need to be used outside of
> mtk_mdp_comp.c
> 
> This patch depends on and is a follow-up to
> 
https://patchwork.kernel.org/project/linux-mediatek/list/?series=524929
> 
> Signed-off-by: Eizan Miyamoto <eizan@...omium.org>
> ---

Reviewed-by: Houlong Wei <houlong.wei@...iatek.com>

>  drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 2 +-
>  drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> index 9527649de98e..2cf8f1864f8c 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> @@ -234,7 +234,7 @@ static const struct component_ops
> mtk_mdp_component_ops = {
>  	.unbind = mtk_mdp_comp_unbind,
>  };
>  
> -int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev)
> +static int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct
> device *dev)
>  {
>  	struct device_node *larb_node;
>  	struct platform_device *larb_pdev;
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> index e3d6aef52869..aa6442cc8c1d 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> @@ -21,8 +21,6 @@ struct mtk_mdp_comp {
>  	struct device		*larb_dev;
>  };
>  
> -int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device
> *dev);
> -
>  int mtk_mdp_comp_power_on(struct mtk_mdp_comp *comp);
>  int mtk_mdp_comp_power_off(struct mtk_mdp_comp *comp);
>  
> -- 
> 2.32.0.605.g8dce9f2422-goog
>