linux-kernel - Re: [PATCH 1/2] ASoC: tegra30: ahub: Use of_device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210816183906.GC4253@sirena.org.uk>
Date:   Mon, 16 Aug 2021 19:39:06 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Aakash Hemadri <aakashhemadri123@...il.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>, Takashi Iwai <tiwai@...e.com>,
        Jawoslav Kysela <perex@...ex.cz>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        alsa-devel@...a-project.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>,
        Bjorn Helgaas <bjorn@...gaas.com>
Subject: Re: [PATCH 1/2] ASoC: tegra30: ahub: Use of_device_get_match_data

On Sun, Aug 15, 2021 at 01:42:18AM +0530, Aakash Hemadri wrote:

> -	match = of_match_device(tegra30_ahub_of_match, &pdev->dev);
> +	match = of_device_get_match_data(&pdev->dev);
>  	if (!match)

Thierry, are you sure about your review here?  As others have been
pointing out of_device_get_match_data() returns match->data while
of_match_device() returns the device.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)