linux-kernel - Re: [PATCH] ARC: export clear_user_page() for modules

Open Source and information security mailing list archives

Message-ID: <16255d77-e9a5-4bac-6c6e-596af6f5b0c1@kernel.org>
Date:   Mon, 16 Aug 2021 15:00:42 -0700
From:   Vineet Gupta <vgupta@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     kernel test robot <lkp@...el.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Vineet Gupta <vgupta@...nel.org>,
        linux-snps-arc@...ts.infradead.org
Subject: Re: [PATCH] ARC: export clear_user_page() for modules

On 8/16/21 2:05 PM, Randy Dunlap wrote:
> 0day bot reports a build error:
>    ERROR: modpost: "clear_user_page" [drivers/media/v4l2-core/videobuf-dma-sg.ko] undefined!
> so export it in arch/arc/ to fix the build error.
>
> In most ARCHes, clear_user_page() is a macro. OTOH, in a few
> ARCHes it is a function and needs to be exported.
> PowerPC exported it in 2004. It looks like nds32 and nios2
> still need to have it exported.
>
> Fixes: 4102b53392d63 ("ARC: [mm] Aliasing VIPT dcache support 2/4")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: Vineet Gupta <vgupta@...nel.org>
> Cc: linux-snps-arc@...ts.infradead.org

Thx for the fix. Added for 5.16 !

-Vineet

> ---
>   arch/arc/mm/cache.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20210816.orig/arch/arc/mm/cache.c
> +++ linux-next-20210816/arch/arc/mm/cache.c
> @@ -1041,7 +1041,7 @@ void clear_user_page(void *to, unsigned
>   	clear_page(to);
>   	clear_bit(PG_dc_clean, &page->flags);
>   }
> -
> +EXPORT_SYMBOL(clear_user_page);
>   
>   /**********************************************************************
>    * Explicit Cache flush request from user space via syscall
>
> _______________________________________________
> linux-snps-arc mailing list
> linux-snps-arc@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-snps-arc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives