linux-kernel - Re: [PATCH v2 1/5] iio: st_sensors: disable regulators after device unregistration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaYLd=R9SjqLF=j94fjbG-urHW6C6rXJ3oGnJM9W78P4g@mail.gmail.com>
Date:   Tue, 17 Aug 2021 00:50:04 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Alexandru Ardelean <aardelean@...iqon.com>
Cc:     linux-iio <linux-iio@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Denis CIOCCA <denis.ciocca@...com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v2 1/5] iio: st_sensors: disable regulators after device unregistration

On Mon, Aug 16, 2021 at 10:30 AM Alexandru Ardelean
<aardelean@...iqon.com> wrote:

> Up until commit ea7e586bdd331 ("iio: st_sensors: move regulator retrieveal
> to core") only the ST pressure driver seems to have had any regulator
> disable. After that commit, the regulator handling was moved into the
> common st_sensors logic.
>
> In all instances of this regulator handling, the regulators were disabled
> before unregistering the IIO device.
> This can cause issues where the device would be powered down and still be
> available to userspace, allowing it to send invalid/garbage data.
>
> This change moves the st_sensors_power_disable() after the common probe
> functions. These common probe functions also handle unregistering the IIO
> device.
>
> Fixes: 774487611c949 ("iio: pressure-core: st: Provide support for the Vdd power supply")
> Fixes: ea7e586bdd331 ("iio: st_sensors: move regulator retrieveal to core")
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Denis CIOCCA <denis.ciocca@...com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Signed-off-by: Alexandru Ardelean <aardelean@...iqon.com>

That's a valid concern I suppose:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

But as it now occurs last before return 0, can't we just solve
this with a
devm_add_action_or_reset(dev, st_sensors_power_off_action, *);
of some kind and let devres handle it?

c.f
drivers/input/touchscreen/cy8ctma140.c

Yours,
Linus Walleij