linux-kernel - Re: [PATCH] leds: flash: Remove redundant initialization of variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210816065110.GA7500@duo.ucw.cz>
Date:   Mon, 16 Aug 2021 08:51:10 +0200
From:   Pavel Machek <pavel@....cz>
To:     Colin King <colin.king@...onical.com>
Cc:     linux-leds@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: flash: Remove redundant initialization of variable
 ret

Hi!

> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable ret is being initialized with a value that is never read,
> it is being updated later on. The assignment is redundant and can be
> removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

I did this instead; hopefully that's okay with everyone.

Best regards,
							Pavel

commit 654933ae7d32f278eecd0bb0f175785574ac4775
Author: Pavel Machek <pavel@....cz>
Date:   Mon Aug 16 08:47:08 2021 +0200

    leds: flash: Remove redundant initialization of variable ret
    
    Adjust initialization not to trigger Coverity warnings.
    
    Reported-by: Colin Ian King <colin.king@...onical.com>
    Signed-off-by: Pavel Machek <pavel@....cz>

diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c
index 6eeb9effcf65..185e17055317 100644
--- a/drivers/leds/led-class-flash.c
+++ b/drivers/leds/led-class-flash.c
@@ -92,14 +92,12 @@ static ssize_t flash_strobe_store(struct device *dev,
 	struct led_classdev *led_cdev = dev_get_drvdata(dev);
 	struct led_classdev_flash *fled_cdev = lcdev_to_flcdev(led_cdev);
 	unsigned long state;
-	ssize_t ret = -EINVAL;
+	ssize_t ret = -EBUSY;
 
 	mutex_lock(&led_cdev->led_access);
 
-	if (led_sysfs_is_disabled(led_cdev)) {
-		ret = -EBUSY;
+	if (led_sysfs_is_disabled(led_cdev))
 		goto unlock;
-	}
 
 	ret = kstrtoul(buf, 10, &state);
 	if (ret)


-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)