linux-kernel - Re: [PATCH V4 7/8] i3c: master: svc: add the missing module device table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210816090020.65e1a908@xps13>
Date:   Mon, 16 Aug 2021 09:00:20 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Clark Wang <xiaoning.wang@....com>
Cc:     conor.culhane@...vaco.com, alexandre.belloni@...tlin.com,
        linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-imx@....com
Subject: Re: [PATCH V4 7/8] i3c: master: svc: add the missing module device
 table

Hi Clark,

Clark Wang <xiaoning.wang@....com> wrote on Mon,  9 Aug 2021 14:36:44
+0800:

> The missing MODULE_DEVICE_TABLE() will cause the svc-i3c-master cannot
> be auto probed when it is built in moudle.
> So add it.
> 
> Signed-off-by: Clark Wang <xiaoning.wang@....com>
> Reviewed-by: Jun Li <jun.li@....com>

Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>

> ---
> V4: New patch in this patchset
> ---
>  drivers/i3c/master/svc-i3c-master.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index 5939e0936697..77f67d407acd 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -1612,6 +1612,7 @@ static const struct of_device_id svc_i3c_master_of_match_tbl[] = {
>  	{ .compatible = "silvaco,i3c-master" },
>  	{ /* sentinel */ },
>  };
> +MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl);
>  
>  static struct platform_driver svc_i3c_master = {
>  	.probe = svc_i3c_master_probe,

Thanks,
Miquèl