linux-kernel - Re: [PATCH v5 3/5] iio: adc: ad7949: add support for internal vref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 16 Aug 2021 11:07:00 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Liam Beguin <liambeguin@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Charles-Antoine Couret <charles-antoine.couret@...ensium.com>,
        Nuno Sá <Nuno.Sa@...log.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v5 3/5] iio: adc: ad7949: add support for internal vref

On Fri, Aug 13, 2021 at 11:51 PM Liam Beguin <liambeguin@...il.com> wrote:
> On Mon Aug 9, 2021 at 3:42 PM EDT, Jonathan Cameron wrote:

...

> > > > > +       /* Read channel specific information form the devicetree */

from

> > > > > +       device_for_each_child_node(dev, child) {
> > > > > +               ret = fwnode_property_read_u32(child, "reg", &i);
> > > > > +               if (ret) {
> > > > > +                       dev_err(dev, "missing reg property in %pfw\n", child);
> > > > > +                       fwnode_handle_put(child);
> > > > > +                       return ret;
> > > > > +               }
> > > > > +
> > > > > +               ad7949_chan = &ad7949_adc->channels[i];
> > > > > +
> > > > > +               ret = fwnode_property_read_u32(child, "adi,internal-ref-microvolt", &tmp);
> > > > > +               if (ret < 0 && ret != -EINVAL) {
> > > > > +                       dev_err(dev, "invalid internal reference in %pfw\n", child);
> > > > > +                       fwnode_handle_put(child);
> > > > > +                       return ret;
> > > > > +               }

> After getting access to another setup to run more tests, I noticed
> that setting the reference per channel isn't really feasible.

Is it a hardware limitation?

-- 
With Best Regards,
Andy Shevchenko