linux-kernel - Re: [PATCH v14 082/138] mm/lru: Convert __pagevec_lru_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YRnLoYRps6HXdTyD@casper.infradead.org>
Date:   Mon, 16 Aug 2021 03:21:21 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     David Howells <dhowells@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-fsdevel@...r.kernel.org, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v14 082/138] mm/lru: Convert __pagevec_lru_add_fn to take
 a folio

On Tue, Aug 10, 2021 at 10:44:27PM +0100, David Howells wrote:
> Matthew Wilcox (Oracle) <willy@...radead.org> wrote:
> 
> >  	 * looking at the same page) and the evictable page will be stranded
> >  	 * in an unevictable LRU.
> 
> Does that need converting to say 'folio'?

Changed the parapgraph (passed it through fmt too)

         * if '#1' does not observe setting of PG_lru by '#0' and
         * fails isolation, the explicit barrier will make sure that
         * folio_evictable check will put the folio on the correct
         * LRU. Without smp_mb(), folio_set_lru() can be reordered
         * after folio_test_mlocked() check and can make '#1' fail the
         * isolation of the folio whose mlocked bit is cleared (#0 is
         * also looking at the same folio) and the evictable folio will
         * be stranded on an unevictable LRU.

> Other than that:
> 
> Reviewed-by: David Howells <dhowells@...hat.com>
>